Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using a bot account. #83

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Using a bot account. #83

merged 4 commits into from
Jun 3, 2019

Conversation

crspeller
Copy link
Member

No description provided.

@crspeller crspeller added the 2: Dev Review Requires review by a core committer label Jun 3, 2019
hanzei
hanzei requested changes Jun 3, 2019
View reviewed changes
server/api.go Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Show resolved Hide resolved
server/command.go Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/webhook.go
@@ -776,16 +658,16 @@ func (p *Plugin) handleCommentMentionNotification(event *github.IssueCommentEven
continue
}

userID := p.getGitHubToUserIDMapping(username)
if userID == "" {
userId := p.getGitHubToUserIDMapping(username)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think go vet was glitching out.

hanzei
hanzei reviewed Jun 3, 2019
View reviewed changes
webapp/package-lock.json Outdated Show resolved Hide resolved
@hanzei
Copy link
Contributor

hanzei commented Jun 3, 2019

Would you also please set "min_server_version": "5.12.0", in the manifest?

@crspeller
Copy link
Member Author

@hanzei Ready for re-review.

jwilander
jwilander approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lieut-data
lieut-data approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment below re: non-configurability of username.

server/plugin.go Show resolved Hide resolved
@crspeller crspeller merged commit 132b7c4 into master Jun 3, 2019
@crspeller crspeller deleted the bot-accounts branch June 3, 2019 17:30
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 3, 2019
hanzei
hanzei reviewed Jun 3, 2019
View reviewed changes
server/plugin.go
@@ -81,13 +85,31 @@ func (p *Plugin) OnActivate() error {
return err
}
p.API.RegisterCommand(getCommand())
user, err := p.API.GetUserByUsername(config.Username)

botId, appErr := p.Helpers.EnsureBot(&model.Bot{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late catch: This is potential dangerous. EnsureBot returns an error, not *model.AppErr. Because of this the checks later can fail. @crspeller Would you please fix this?

@crspeller crspeller mentioned this pull request Jun 3, 2019
Closed
@jasonblais jasonblais mentioned this pull request Feb 15, 2020
Closed
@hanzei hanzei mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei requested changes

@jwilander jwilander jwilander approved these changes

@lieut-data lieut-data lieut-data approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crspeller @hanzei @lieut-data @jwilander